Vehicle rental overlay graphql migration #1440
Open
+186
−120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-graphql-migration
…-graphql-migration
…icle-rental-overlay-graphql-migration
…-graphql-migration
…l-overlay-graphql-migration
…-graphql-migration
…-graphql-migration
…tal-overlay-graphql-migration
…-graphql-migration
daniel-heppner-ibigroup
requested changes
Nov 6, 2025
| const micromobility = rentalVehicles.filter( | ||
| (vehicle) => | ||
| vehicle.vehicleType && | ||
| vehicle.vehicleType?.formFactor !== FormFactor.CAR |
There was a problem hiding this comment.
This will filter out any vehicles where vehicleType is undefined. Is that intentional? Do scooters/bikes never have undefined? Under what circumstance can it be undefined?
You should be able to remove the ? from the second part of the condition since the null check has already happened.
| setLocation: any | ||
| setViewedStop: any | ||
| viewedRouteStops: any | ||
| } |
There was a problem hiding this comment.
I think you could define a bunch of these. There are some low hanging fruit like intl -> IntlShape.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates the
bikeRentalQueryto use graphQL instead of the deprecated REST endpoint.Note that the updates to OTP-UI found in this PR must be merged to correctly use the response that comes back from graphQL.PR Checklist: